Use driver for formatter tests #4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In c0125d8, some tests passing `Hash` directly to `Fluent::Plugin::Base::configure()` are fixed so that passing `Fluent::Config::Element`. However, a part of those tests should use the test-driver, and then we can passing `Hash` to the driver safely. Signed-off-by: Daijiro Fukuda <[email protected]>
|
@abetomo Could you please check this if there are any problems with the direction of this fix? |
|
I should have used |
|
@abetomo Thanks for your review!
It's no problem! FYI: The document of |
|
Thanks! |
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None. This is the following fix to
Fluent::Config::Elementin test #4074What this PR does / why we need it:
Fluent::Config::Elementin test #4074In this PR, some tests passing
Hashdirectly toFluent::Plugin::Base::configure()are fixed so that passingFluent::Config::Element.However, a part of those tests should use the test-driver, and then we can passing
Hashto the driver safely.Docs Changes:
None.
Release Note:
None.