Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Webrick #4061

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Update Webrick #4061

merged 1 commit into from
Mar 15, 2023

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Feb 18, 2023

Which issue(s) this PR fixes:
Fixes #4060

What this PR does / why we need it:
This PR allows us to use the latest Webrick v1.8.

https://github.com/ruby/webrick/releases

Without this fix, plugins using the latest version of Webrick tries to bundle the Fluentd v1.12.1.

Docs Changes:
Not needed.

Release Note:
Not needed.

@daipom
Copy link
Contributor Author

daipom commented Feb 18, 2023

TODO confirm test results.

@daipom
Copy link
Contributor Author

daipom commented Feb 18, 2023

All Windows tests fail:

"fatal: not enough memory for initialization

The fluentd command fails by

[BUG] transient_heap_block_alloc: failed

@daipom
Copy link
Contributor Author

daipom commented Feb 18, 2023

All Windows tests fail:

"fatal: not enough memory for initialization

The fluentd command fails by

[BUG] transient_heap_block_alloc: failed

These tests have failed before as well.

In my local Ruby3.1 on Windows 10 Home, all tests in TestFluentdCommand is successful.

@daipom
Copy link
Contributor Author

daipom commented Feb 18, 2023

I will run all tests in my local Ruby3.2 on Windows 10 Home.

@daipom
Copy link
Contributor Author

daipom commented Feb 18, 2023

I have confirmed all tests are successful on my local environment.

  • Windows 10 Home
  • Ruby 3.2

@daipom daipom changed the title Draft: Update Webrick Update Webrick Feb 18, 2023
@ashie
Copy link
Member

ashie commented Feb 20, 2023

I rerun CI for this PR a few times but always fail on Windows platform & all Ruby versions.
Something might be broken on Windows.

They output suspicious log after finishing test:
https://pipelines.actions.githubusercontent.com/serviceHosts/dcea8a2b-d3f2-46b4-98c3-e49156744027/_apis/pipelines/1/runs/5739/signedlogcontent/4?urlExpires=2023-02-20T01%3A08%3A30.7621547Z&urlSigningMethod=HMACV1&urlSignature=Xwoey9RfUNCHigksWBcJsyVRjp3lxmDW5vDV0zrNbEI%3D

2023-02-20T00:45:27.7627491Z Cleaning up orphan processes
2023-02-20T00:45:27.7899895Z Terminate orphan process: pid (6924) (ruby)
2023-02-20T00:45:27.7954214Z Terminate orphan process: pid (6860) (ruby)
2023-02-20T00:45:27.8164435Z Terminate orphan process: pid (6100) (ruby)
2023-02-20T00:45:27.8222072Z Terminate orphan process: pid (6900) (ruby)
2023-02-20T00:45:27.8478316Z Terminate orphan process: pid (2844) (ruby)
2023-02-20T00:45:27.8526378Z Terminate orphan process: pid (6892) (ruby)
2023-02-20T00:45:27.8573093Z Terminate orphan process: pid (1580) (ruby)
2023-02-20T00:45:27.8785154Z Terminate orphan process: pid (1596) (ruby)
...

@daipom
Copy link
Contributor Author

daipom commented Feb 20, 2023

Thanks for confirming!
Indeed, it looks like something broken...
I will investigate it.

@daipom daipom changed the title Update Webrick Draft: Update Webrick Feb 20, 2023
@daipom daipom marked this pull request as draft February 21, 2023 14:28
Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom
Copy link
Contributor Author

daipom commented Mar 14, 2023

I'm not sure what was going on, but it looks fine now?

@daipom daipom marked this pull request as ready for review March 15, 2023 09:04
@daipom daipom changed the title Draft: Update Webrick Update Webrick Mar 15, 2023
@daipom daipom requested a review from ashie March 15, 2023 09:04
@daipom
Copy link
Contributor Author

daipom commented Mar 15, 2023

I'm not sure what was happening, but now this seems to be working with no problem.

@ashie ashie merged commit 1b8dee1 into fluent:master Mar 15, 2023
@ashie ashie added this to the v1.16.0 milestone Mar 15, 2023
@ashie
Copy link
Member

ashie commented Mar 15, 2023

Thanks!

@daipom daipom deleted the update-webrick branch March 16, 2023 00:55
@daipom
Copy link
Contributor Author

daipom commented Mar 16, 2023

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency: Update Webrick version limitation
2 participants