-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Webrick #4061
Update Webrick #4061
Conversation
TODO confirm test results. |
All Windows tests fail:
The fluentd command fails by
|
These tests have failed before as well. In my local Ruby3.1 on Windows 10 Home, all tests in |
I will run all tests in my local Ruby3.2 on Windows 10 Home. |
I have confirmed all tests are successful on my local environment.
|
I rerun CI for this PR a few times but always fail on Windows platform & all Ruby versions. They output suspicious log after finishing test:
|
Thanks for confirming! |
Signed-off-by: Daijiro Fukuda <[email protected]>
I'm not sure what was going on, but it looks fine now? |
I'm not sure what was happening, but now this seems to be working with no problem. |
Thanks! |
Thanks for your review! |
Which issue(s) this PR fixes:
Fixes #4060
What this PR does / why we need it:
This PR allows us to use the latest
Webrick
v1.8.https://github.com/ruby/webrick/releases
Without this fix, plugins using the latest version of
Webrick
tries to bundle the Fluentd v1.12.1.Docs Changes:
Not needed.
Release Note:
Not needed.