Disable sigdump after stop #4043
Conversation
Signed-off-by: abetomo <[email protected]>
There was a problem hiding this comment.
LGTM. Thanks for the fix!
I have checked that Fluentd as a Windows Service can dump correctly by $ fluent-ctl dump.
What about Docs Changes and Release Note?
Docs Changes is the fix of https://github.com/fluent/fluentd-docs-gitbook corresponding to this fix.
I think we don't need it this time.
Release Note is used for https://github.com/fluent/fluentd/blob/master/CHANGELOG.md.
This is often the same as the title of the PR, but I think it is worth considering a little more this time.
|
Merged. Thanks!
I also think it's not needed for this. |
How about "Change to not generate a sigdump file after receiving a SIGTERM signal on non-Windows"? |
Great! |
Which issue(s) this PR fixes:
Fixes #3932
What this PR does / why we need it:
Don't generate sigdump files after stopping.
#4034 (comment)
Docs Changes:
None
Release Note:
Change to not generate a sigdump file after receiving a SIGTERM signal on non-Windows