Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace $$ with Process.pid #4040

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Replace $$ with Process.pid #4040

merged 1 commit into from
Feb 7, 2023

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Feb 6, 2023

Which issue(s) this PR fixes:

( #4034 (comment) )

What this PR does / why we need it:

Simply replace $$ with Process.pid.
Process.pid is easier to read and understand.

Docs Changes:

Release Note:

@abetomo abetomo changed the title Replace $$ with Process.pid. Replace $$ with Process.pid Feb 6, 2023
`Process.pid` is easier to understand.

Signed-off-by: abetomo <[email protected]>
@ashie
Copy link
Member

ashie commented Feb 7, 2023

GJ! Thanks!

@ashie
Copy link
Member

ashie commented Feb 7, 2023

Failed tests are known issue, they aren't concerned with this patch.

@ashie ashie merged commit 931e16e into fluent:master Feb 7, 2023
@abetomo abetomo deleted the use_process_pid branch February 7, 2023 01:51
@ashie ashie added this to the v1.16.0 milestone Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants