buffer: add log for time periods of restored chunks which may be broken#4028
Merged
ashie merged 2 commits intofluent:masterfrom Jan 27, 2023
Merged
Conversation
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Contributor
Author
|
Thanks for merging! |
daipom
added a commit
to daipom/fluentd-docs-gitbook
that referenced
this pull request
Mar 29, 2023
* fluent/fluentd#4025 * fluent/fluentd#4028 Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Partial fix for #3970
What this PR does / why we need it:
Add logs of possible time periods of buffer corruption during buffer resumimg.
When one of the remaining chunk files is broken at the resuming, this logs
created_atandmodified_atof other files undetected.Fluentd can detect the corruption when the meta-data is broken, but can't when the chunk file is broken.
So if one corruption is detected, we should assume that other files may also be broken.
This allows us to know other possible time periods of corruption.
Docs Changes:
Release Note:
Add logs for time period of restored buffer possibly broken.
How to Reproduce
$ head -c 89 /dev/zero > buffer.b5f32716d72fc5d71592aa89c5865fd48.log.meta