buffer: warning message for restoring buffer with flush_at_shutdown #4027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daijiro Fukuda <[email protected]>
|
Thanks for your review! Yes, please! |
ashie
requested changes
Jan 27, 2023
|
Indeed! I will add the comment to the code. |
Signed-off-by: Daijiro Fukuda <[email protected]>
|
I have added the comment at 0807567. |
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Partial fix for #3970
What this PR does / why we need it:
When
flush_at_shutdownistrue, the remaining chunk files during resuming are possibly broken since there may be a power failure or similar failure.Without this log, even if we notice that we have received corrupted data on the destination server, we can not know which chunks may have been corrupted.
Docs Changes:
Not needed.
Release Note:
Add warning messages for restoring buffer with
flush_at_shutdown true.