in_forward: Add tag and add_tag_prefix parameters #2396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masahiro Nakagawa <[email protected]>
ganmacs
reviewed
Apr 24, 2019
| @@ -293,6 +298,9 @@ def on_message(msg, chunk_size, conn) | |||
| log.warn "Input chunk size is larger than 'chunk_size_warn_limit':", tag: tag, host: conn.remote_host, limit: @chunk_size_warn_limit, size: chunk_size | |||
| end | |||
|
|
|||
| tag = @tag.dup if @tag | |||
| tag = "#{@add_tag_prefix}.#{tag}" if @add_tag_prefix | |||
There was a problem hiding this comment.
Is it ok without checking tag is an empty string?
There was a problem hiding this comment.
Ah, good catch. I will add empty check on configure.
|
Yeah, label is one good approach but label itself doesn't change tag. |
ganmacs
approved these changes
Apr 25, 2019
Signed-off-by: Masahiro Nakagawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masahiro Nakagawa [email protected]
Which issue(s) this PR fixes:
none
What this PR does / why we need it:
I sometimes receive this request from users for aggregator.
There are several reasons:
We can simulate this by adding new field for cluster detection in forwarder side and check it in aggregator side. But it makes configuration complicated.
We can rewrite tag with
routeor similar plugins but it has performance penalty for large traffic.The implementation is very simple and it resolves above cases. So supporting these parameters is reasonable.
Docs Changes:
Will send a patch to fluentd-docs after merged.
Release Note:
Same as title.