Added possibility of return other types instead of Action from BotM monad. #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted examples with new API.
…umentation for RunBot typeclass
|
There are two things:
✅ LGTM. Typos and texts could be improved further in the next PR before release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this moment we have botHandler, that assumes user-defined Action-s and BotM monad into this handler where you make all API-requests. In this monad you must return new Action that goes back to the handler. With this design user needs to create NoOp -Action that doesn't produce any BotM-actions and therefore does not produce new Action-s.
This PR creates solver, that can works with arbitrary return types, that have RunBot a Action-instance.