Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports #8

Closed
arnaud-lb opened this issue Feb 6, 2017 · 7 comments
Closed

Imports #8

arnaud-lb opened this issue Feb 6, 2017 · 7 comments

Comments

@arnaud-lb
Copy link

This package doesn't seem to support files that have import statements. Is there a way to use such files currently ?

exprotobuf seems to support import statements when providing all the imported files explicitly, however I can't find a way to do that with grpc-elixir.

@tony612
Copy link
Collaborator

tony612 commented Feb 6, 2017

It's indeed an issue. I'm trying to support this recently. exprotobuf and gpb support import, but some work is still needed to integrate with gRPC.

@tony612
Copy link
Collaborator

tony612 commented Feb 7, 2017

Some thoughts about this feature: The current implement(mix task) and protoc-erl(what gpb implements) may be wrong. The right solution should be writing a plugin for the official protoc as here mentions(though the doc doesn't provide details about writing a plugin).

@alexander-alvarez
Copy link

it's defined here:

A plugin is just a program which reads a CodeGeneratorRequest protocol buffer from standard input and then writes a CodeGeneratorResponse protocol buffer to standard output.

and the definition for those are given here:
https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.compiler.plugin.pb

I might take a stab at it when cycles free up

@tony612
Copy link
Collaborator

tony612 commented Mar 14, 2017

@alexander-alvarez Thank you. I already found it last month. btw, I'm trying to implement that by Elixir recently, but it will take some time 😀

@alexander-alvarez
Copy link

@tony612 you doing it as a separate application?

@tony612
Copy link
Collaborator

tony612 commented Mar 14, 2017

@alexander-alvarez I'm trying to create a plugin for protoc to generate the Elixir code from the proto file.

@tony612
Copy link
Collaborator

tony612 commented Aug 5, 2017

exprotobuf is replaced by protobuf now. So import has been supported. Doc is coming :)

@tony612 tony612 closed this as completed Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants