-
Notifications
You must be signed in to change notification settings - Fork 3
feat: api history #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first pass at review, leaving it for now to allow for discussion on the larger change being requested.
Co-authored-by: David Sanders <[email protected]>
Signed-off-by: Piotr Płaczek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments but I think we're getting close!
Co-authored-by: David Sanders <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed two final commits and gonna merge:
- Would prefer to retain the
.md
extension instead of.md.api-history
- Restored
yarn.lock
and didyarn install
myself to align with our policy on maintainers making lockfile changes. This ended up bumping some versions of things which seems fine.
I renamed it because using
👍 |
I see that now. 😅 Pushed a commit to ignore it in those tests. |
Signed-off-by: David Sanders <[email protected]>
Signed-off-by: David Sanders <[email protected]>
Signed-off-by: David Sanders <[email protected]>
a58682e
to
4f988c9
Compare
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Note
This PR is part of the 2024 Electron GSoC [Project] [Proposal].
Linting script for the API History blocks in
electron/docs/*.md
.@dsanders11 @erickzhao @VerteDinde