-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add initial buildkite pipeline for Benchmark #16190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hosts: | ||
- "localhost:5044" | ||
compression_level: 0 | ||
pipelining: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, why 3? I'd suggest leaving the default here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree to maintain the default behavior.
Base on my last benchmark test, 3 gave more eps.
input { | ||
beats { | ||
port => 5044 | ||
enrich => none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe keep enrich at its default so we know what is the out-of-the-box performance for Logstash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default enrich
will duplicate the size of event. But I think the size doesn't matter in this test. I mainly want to get the trend of benchmark result.
Removed the line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
💚 Build Succeeded
History
|
skeleton pipeline for development