Skip to content

Add initial buildkite pipeline for Benchmark #16190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 31, 2024

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented May 31, 2024

skeleton pipeline for development

@kaisecheng kaisecheng changed the title add benchmark pipeline Add initial buildkite pipeline for Benchmark May 31, 2024
@kaisecheng kaisecheng marked this pull request as ready for review May 31, 2024 12:33
hosts:
- "localhost:5044"
compression_level: 0
pipelining: 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, why 3? I'd suggest leaving the default here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree to maintain the default behavior.
Base on my last benchmark test, 3 gave more eps.

input {
beats {
port => 5044
enrich => none
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe keep enrich at its default so we know what is the out-of-the-box performance for Logstash?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default enrich will duplicate the size of event. But I think the size doesn't matter in this test. I mainly want to get the trend of benchmark result.
Removed the line

@kaisecheng kaisecheng requested a review from jsvd May 31, 2024 13:53
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@kaisecheng kaisecheng merged commit 1d4038b into elastic:main May 31, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants