Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding resolveConcreteIndexNames to DataStreamsActionUtil #106621

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Adding resolveConcreteIndexNames to DataStreamsActionUtil #106621

merged 2 commits into from
Mar 21, 2024

Conversation

ldematte
Copy link
Contributor

Extract method resolveConcreteIndexNames from DataStreamsStatsTransportAction to DataStreamsActionUtil, and move the whole class to the server module, so it can be shared and used across plugins.

@ldematte
Adding resolveConcreteIndexNames to DataStreamsActionUtil, and movi…
2a9edcc 
…ng it to server so it can be shared across plugins
@ldematte ldematte added :Data Management/Stats Statistics tracking and retrieval APIs >refactoring labels Mar 21, 2024
@ldematte ldematte requested a review from masseyke March 21, 2024 16:33
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team v8.14.0 labels Mar 21, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

masseyke
masseyke approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have a unit test, but this is just a move of code that already existed w/o a unit test so we're no worse off.

@ldematte ldematte added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 21, 2024
@elasticsearchmachine elasticsearchmachine merged commit a960bef into elastic:main Mar 21, 2024
14 checks passed
@ldematte ldematte deleted the move-datastream-action-util branch March 21, 2024 23:53
This was referenced Mar 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masseyke masseyke masseyke approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Stats Statistics tracking and retrieval APIs >refactoring Team:Data Management Meta label for data/management team v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldematte @elasticsearchmachine @masseyke