Bugfix: Change queryStringParameters to HashMap #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Query params type fix: HashMap. This change currently uses a fork, but will be updated, once theam/aws-lambda-haskell-runtime was updated and released. See <theam/aws-lambda-haskell-runtime#85>
|
Thanks Andy! I'll merge that and get it up on Hackage together with the print statement removal. |
|
Thank you. But I think it also needs to have |
|
@andys8 Yeah, definitely. Let's wait a bit and see. It's better to have the fixed fork up on Hackage for now. |
andys8
added a commit
to andys8/aws-lambda-haskell-runtime-wai
that referenced
this pull request
Aug 7, 2020
Fork not necessary anymore because the changes were merged upstream. Relates to eir-forsakring#4 Relates to <theam/aws-lambda-haskell-runtime#87>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There is currently an issue with
aws-lambda-haskell-runtimewhere query parameters are not working as expected. It leads to anAesoncrash.theam/aws-lambda-haskell-runtime#85
Therefore I propose this fix to
aws-lambda-haskell-runtime.theam/aws-lambda-haskell-runtime#87
This library is currently using
aws-lambda-haskell-runtimein version3.0.0. Because the fix is breaking the type signature, this PR is an update to adapt it.It currently uses a fork of mine where the issue is fixed and the change is necessary. Once the upstream library is fixed and published, this PR can be adapted and merged.
Thanks for the wai library by the way 😌