Update ICSharpCode.Decompiler to 8.2.0.7535

[christophwille]

Version 8.2 has a couple of important performance fixes:

• TopologicalSort stack overflow when decompiling long method icsharpcode/ILSpy#3075: Avoid processing already-transformed blocks by introducing BlockTransformContext.IndexOfFirstAlreadyTransformedInstruction, which allows us to track already transformed instructions after a block has been merged into another by ConditionDetection.
  • Add NextSetBit operation to BitSet to avoid looking at every store bit individually in ReachingDefinitionsVisitor.GetStores()
  • Fix ILVariableEqualityComparer.GetHashCode
  • Improve performance of CSharpResolver.LookupSimpleNameOrTypeName in cases with a large number of local variables.
  • Eliminate recursion in some parts of the decompiler engine

Aside from that, a lot of language features landed that are relevant:

New Language Features

• C# 7.1 Pattern matching with generics
• C# 8.0 Recursive patterns
• C# 9.0 Relational patterns
• C# 9.0 not patterns
• C# 10.0 static abstract members in interfaces
• C# 11.0 switch on (ReadOnly)Span<char>

The release is now 3 months in production with no showstopers or critical bugs.

[christophwille]

@sharwell given that your bug report triggered those performance optimizations, wouldn't that actually be of interest for Roslyn?

[christophwille]

We just released 9.0 - is upgrading to newer versions in Roslyn still something someone is interested in?

[dibarbet]

I can work on getting this in. For now will take the 8.2 update, and can do 9.0 once this one goes in smoothly.

[christophwille]

I can work on getting this in. For now will take the 8.2 update, and can do 9.0 once this one goes in smoothly.

We usually always waited two or three months to see if anything bad slipped into the engine (but so far at least nothing).