Support DocumentSymbol
results from Roslyn
#10560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our custom message target currently returns
SumType<DocumentSymbol[], SymbolInformation[]>?
but our endpoint blindly assumesSymbolInformation[]?
is the return type. This is a bad thing because Roslyn can return either type, based on a client capability, and even the spec notes:This PR adds support for
DocumentSymbol
to our langauge server, and tests that cover both possible result types.