Skip to content

Fixed #1313 -- Improve accessibility on warning admonitions #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2023
Merged

Fixed #1313 -- Improve accessibility on warning admonitions #1360

merged 2 commits into from
May 22, 2023

Conversation

sabderemane
Copy link
Member

@sabderemane sabderemane commented May 16, 2023 •
edited
Loading

Before the changes :
Capture d’écran 2023-05-11 à 02 27 22

Capture d’écran 2023-05-12 à 01 07 38

After the changes:
Capture d’écran 2023-05-11 à 02 27 29

Capture d’écran 2023-05-12 à 01 08 11

cc @django/accessibility

@sabderemane sabderemane requested a review from a team May 19, 2023 16:57
@sabderemane sabderemane mentioned this pull request May 19, 2023
Closed
pauloxnet
pauloxnet approved these changes May 20, 2023
View reviewed changes
Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

knyghty
knyghty approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@knyghty knyghty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice and less jarring! 🚀

Colours are also accessible, of course.

@pauloxnet pauloxnet merged commit 1b2823b into django:main May 22, 2023
@sabderemane sabderemane deleted the warning-admonitions branch September 13, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloxnet pauloxnet pauloxnet approved these changes

@knyghty knyghty knyghty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sabderemane @pauloxnet @knyghty