Skip to content

Clean-slate redesign/simplification of Backend class #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 31, 2014

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Mar 31, 2014

See https://raw.githubusercontent.com/diagrams/diagrams-doc/master/notes/backend-data-flow.jpg (note the diagram is not quite right since the Options should get transformed by the adjust step too).

  • Remove constraints on Render type (note we still need it to be able to express the Renderable class)
  • Merge doRender and renderData into one function, renderRTree.
  • Move renderDia and renderDiaT out of the Backend class. Allowing backends to implement them directly, instead of in terms of renderRTree and adjustDia (the default) was not buying us anything.
  • Get rid of NullPrim since it is hard to define without a Monoid constraint on Render, and it turns out we don't need it anyway.

jeffreyrosenbluth added a commit that referenced this pull request Mar 31, 2014
Clean-slate redesign/simplification of `Backend` class
@jeffreyrosenbluth jeffreyrosenbluth merged commit 7a62541 into units Mar 31, 2014
@jeffreyrosenbluth jeffreyrosenbluth deleted the units-simple-backend branch March 31, 2014 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants