Fix type-checking bug for unions #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Haskell implementation was not matching the specification for type-checking union types: * The inferred type of union types was (incorrectly) always returning `Type` * Unions of mixed alternative types were not being properly rejected I also discovered several mistakes in the error messages, which I fixed along the way.
Gabriella439
added a commit
to dhall-lang/dhall-lang
that referenced
this pull request
Dec 20, 2018
Thes tests are inspired by mistakes in the Haskell implementation: dhall-lang/dhall-haskell#763
Gabriella439
added a commit
to dhall-lang/dhall-lang
that referenced
this pull request
Dec 22, 2018
Thes tests are inspired by mistakes in the Haskell implementation: dhall-lang/dhall-haskell#763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Haskell implementation was not matching the specification for
type-checking union types:
TypeI also discovered several mistakes in the error messages, which I fixed along
the way.