Left factor parser for function types #606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108
This gives a massive (~30x) parsing performance improvement for the benchmark
code from the above issue:
After:
The root cause was that the parser for function types was introducing
excessive backtracking. This led to parsing performance being exponential
in the number of atomic
operatorExpression
s.This change left-factors the
expression
parser by guttingannotatedExpression
. Specifically, this moves the logic for parsing unannotatedList
/Optional
/merge
intoexpression
and then consolidates theremaining logic for parsing an ordinary
Annot
intoexpression
, applyinga fixup for unannotated
List
/Optional
/merge
expressions to tag them withtheir annotation.