Skip to content

Build on older versions of GHC #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Conversation

Gabriella439
Copy link
Collaborator

CI only tests GHC 8.4, so it missed the fact that Dhall.Util does not build
on GHC 8.0 or GHC 8.2 due to missing a Data.Monoid import, which this fixes.

I also plan to separately fix CI to test building on GHC 8.0 to prevent this from
recurring

CI only tests GHC 8.4, so it missed the fact that `Dhall.Util` does not build
on GHC 8.0 or GHC 8.2 due to missing a `Data.Monoid` import, which this fixes.
@Gabriella439 Gabriella439 merged commit 6e71803 into master Sep 21, 2018
@Gabriella439 Gabriella439 deleted the gabriel/import_monoid branch September 21, 2018 00:56
@jneira
Copy link
Collaborator

jneira commented Sep 21, 2018

Would be possible to test ghc 7.10.3? Eta is built with this version...

@Gabriella439
Copy link
Collaborator Author

@jneira: I just tried this yesterday and the problem I ran into is that at least one of Dhall's transitive dependencies (basement) only builds on GHC 8.0 or newer. I think that probably the more reliable way to verify this is to build with Eta directly if we get etaPackages working because that's a more accurate check than building with GHC 7.10.

@jneira
Copy link
Collaborator

jneira commented Oct 1, 2018

mmm that would be nice too, but i am afraid that etlas are built with ghc 7.10.3 and now it has dhall as transitive dependency.
Eta itself is 7.10.3 but it has some extensions from ghc >= 8 and base <= 4.11.1. It would be possible then that eta could build dhall but ghc 7.10 could not build dhall for etlas. 🤔
So far we have been able to build etlas with dhall using the stack-lts-6 file in dhall-haskell, that uses basement-0.0.6.

@Gabriella439
Copy link
Collaborator Author

@jneira: I see what you mean now. Yeah, in that case, I'll try to get it to build against ghc-7.10 then and pin basement to an older version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants