Improve cache warning messages #2095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The immediate motivation for this fix is to ensure that command-line utilities other than `dhall` correctly warn about issues with cache directories. The main change along those lines is to move the cache check from the `Dhall.Main` module to checking on the fly as cache files are read/written. However, in order to avoid going back to too many cache warnings this also includes logic to avoid warning more than once by tracking a `cacheWarning` state `Bool`. This also includes a small improvement to the permissions error message to better render the directory permissions.
sjakobi
reviewed
Nov 16, 2020
… as suggested by @sjakobi
sjakobi
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The immediate motivation for this fix is to ensure that
command-line utilities other than
dhallcorrectly warn aboutissues with cache directories, as reported in:
#2091 (comment)
The main change along those lines is to move the cache check from
the
Dhall.Mainmodule to checking on the fly as cache files areread/written. However, in order to avoid going back to too many
cache warnings this also includes logic to avoid warning more than
once by tracking a
cacheWarningstateBool.This also includes a small improvement to the permissions error
message to better render the directory permissions.