Correctly escape '${
#2083
Merged
Correctly escape '${
#2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2078 Previously the pretty-printer would escape `'${` as `'''${` inside of a multi-line string, but that escape sequence is incorrect because `'''` is itself an escape sequence for `''`. The solution is to instead escape `'${` as `${"'"}${`
Closed
mmhat
reviewed
Oct 29, 2020
Indeed. I think that's just a little mistake in the description though. The test output looks correct, I think. |
|
Shouldn't we also escape the |
|
Oh yes you're right! I did look at the test, but I guess I didn't parse it correctly. Sorry about that 😅 |
|
No worries, @basile-henry. I was initially surprised too! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2078
Previously the pretty-printer would escape
'${as'''${inside ofa multi-line string, but that escape sequence is incorrect because
'''is itself an escape sequence for''. The solution is toinstead escape
'${as${"'"}${