Skip to content

Fix dhall freeze --cache and dhall lint to preserve comments #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2019
Merged

Fix dhall freeze --cache and dhall lint to preserve comments #1597

merged 2 commits into from
Dec 7, 2019

Conversation

Gabriella439
Copy link
Collaborator

Fixes #1586

sjakobi
sjakobi approved these changes Dec 7, 2019
View reviewed changes
Copy link
Collaborator

@sjakobi sjakobi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I was also working on #1586 – that's why I had assigned the issue to me.

But I like your use of ViewPatterns better! :)

@Gabriella439
Copy link
Collaborator Author

@sjakobi: Whoops! I didn't see that you had assigned it

@sjakobi
Copy link
Collaborator

sjakobi commented Dec 7, 2019

No worries @Gabriel439. Thanks for the elegant fix! :)

@Gabriella439
Copy link
Collaborator Author

@sjakobi: You're welcome! 🙂

@mergify mergify bot merged commit 321c02f into master Dec 7, 2019
@mergify mergify bot deleted the gabriel/1568 branch December 7, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
merge me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dhall freeze --cache and dhall lint remove comments on let-bindings
2 participants
@Gabriella439 @sjakobi