-
Notifications
You must be signed in to change notification settings - Fork 219
Improved error messages. #1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improved error messages. #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch improves some of the error messages: 1) Bad field names on record completion: ``` echo "{Type = {x : Integer, y : Bool}, Default = {y = True}}::{x = 5}" |stack exec dhall Use "dhall --explain" for detailed errors Error: Completion record is missing a field: default 1│ {Type = {x : Integer, y : Bool}, Default = {y = True}}::{x = 5} (stdin):1:1 ``` 2) Trying to complete non-records: ``` Use "dhall --explain" for detailed errors Error: You can only complete records 1│ True::{x = 5} (stdin):1:1 ``` 3) Possibly better short message on if predicates ``` echo "if 1 then 2 else 3" |stack exec dhall Use "dhall --explain" for detailed errors Error: Invalid predicate for ❰if❱: Natural 1│ if 1 then 2 else 3 (stdin):1:1 ``` 4) Possibly better short message on list annotations. This is probably superfluous ``` echo "[] : Bool" |stack exec dhall Use "dhall --explain" for detailed errors Error: Invalid type for ❰List❱: Bool 1│ [] : Bool ``` 5) Better short message on missing constructors: ``` echo "<Foo : Bool>.Boo True" |stack exec dhall Use "dhall --explain" for detailed errors Error: Missing constructor: Boo 1│ <Foo : Bool>.Boo (stdin):1:1 ``` 6) Better short messages on missing handlers
sjakobi
reviewed
Nov 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvements!
Co-Authored-By: Simon Jakobi <[email protected]>
Gabriella439
approved these changes
Nov 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Just one minor comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves some of the error messages, but I didn't manage to make a really reasonable progress before running out of time.
superfluous