Skip to content

Do not warn about cache on --no-cache. #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

StevenXL
Copy link
Contributor

First time contributor to the project. (Trying to get my Hacktoberfest PRs in!)

This does not address the main point of #1404 but it is a point brought up in that issue.

P.S. I am partial to the use of when and not instead of unless, but not a big deal if maintainers would like to change that.

Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome and cheers! :)

@StevenXL
Copy link
Contributor Author

Welcome and cheers! :)

Thank you - I just realized why this issue was brought up in #1404 - once we add the --no-cache flag to the payload of Resolve and Type, the code here will have to change; luckily, the change is minor and I will get to it.

@mergify mergify bot merged commit 9d739b5 into dhall-lang:master Oct 18, 2019
@StevenXL StevenXL deleted the disable-warning-on-no-cache-flag branch October 19, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants