Always break annotated let-bindings #1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjakobi
commented
Oct 2, 2019
|
|
||
| let {- 0 -} y | ||
| {- 1 -} : {- 2 -} Bool |
There was a problem hiding this comment.
It might look nicer to move the {- 1 -} to the line above. no? IMHO the rest of the line after the variable is the best position for a comment.
There was a problem hiding this comment.
The handling of line comments is already pretty reasonable though. I might come back to this later.
e3d2a46 to
1c5000a
Compare
Gabriella439
approved these changes
Oct 4, 2019
|
|
||
| let {- 0 -} y | ||
| {- 1 -} : {- 2 -} Bool |
1c5000a to
33d4366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1370.