Consistently format multi-line strings #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #973 The formatter was behaving consistently for multi-line strings depending on whether or not they were at the top level or nested as a subexpression. For example, the same multi-line string would be rendered in multi-line form if it was at the top level and rendered compactly if nested within another expression. The root cause was that the pretty-printing logic was missing a top-level `Pretty.group` call (which is the function responsible for enabling compact representations if they fit), which this change fixes.
sjakobi
reviewed
Jul 2, 2019
sjakobi
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #973
The formatter was behaving consistently for multi-line strings
depending on whether or not they were at the top level or nested as
a subexpression. For example, the same multi-line string would be
rendered in multi-line form if it was at the top level and rendered
compactly if nested within another expression.
The root cause was that the pretty-printing logic was missing a top-level
Pretty.groupcall (which is the function responsible for enablingcompact representations if they fit), which this change fixes.