Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbex/97956-separation-location-string: separation location code to string #19646

Merged

Conversation

aurora-a-k-a-lightning
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): YES
  • add missing separationLocationCode path

Related issue(s)

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Copy link

Backend-review-group approval confirmed.

@aurora-a-k-a-lightning aurora-a-k-a-lightning merged commit b40aa20 into master Nov 29, 2024
58 of 59 checks passed
@aurora-a-k-a-lightning aurora-a-k-a-lightning deleted the dbex/97956-separation-location-string branch November 29, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants