Allow sharing files with guest using UI, even with custom profile #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 9p filesystem is always accessible by the guest, even if the UI is hidden. This will make the file picker UI be shown when needed; all the user has to do is run `ls` on the 9p mount.
copy
reviewed
Jul 12, 2022
src/browser/main.js
Outdated
| // Hide the filesystem panel for now | ||
| $("filesystem_panel").style.display="none"; | ||
| // Show the filesystem panel if it's ever used | ||
| emulator.add_listener("9p-read-start", function(args) { |
There was a problem hiding this comment.
I'd suggest to add this.bus.send("9p-attach"); here: https://github.com/copy/v86/blob/master/lib/9p.js#L736
and use it instead of 9p-read-start.
hello-smile6
commented
Jul 12, 2022
| @@ -733,6 +733,7 @@ Virtio9p.prototype.ReceiveRequest = async function (bufchain) { | |||
| marshall.Marshall(["Q"], [inode.qid], this.replybuffer, 7); | |||
| this.BuildReply(id, tag, 13); | |||
| this.SendReply(bufchain); | |||
| this.bus.send("9p-attach"); | |||
There was a problem hiding this comment.
Will this have a performance impact?
|
Cheers! |
|
@copy Works perfectly! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 9p filesystem is always accessible by the guest, even if the UI is hidden. This will make the file picker UI be shown when needed; all the user has to do is run
lson the 9p mount.