benches: add a new wasi-demo-{app, oci} benchmark #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2efd4a2 to
9b729b4
Compare
jsturtevant
reviewed
Dec 6, 2024
benches/containerd-shim-benchmarks/benches/wasi-demo-app-benchmarks.rs
Outdated
Show resolved
Hide resolved
jsturtevant
reviewed
Dec 6, 2024
benches/containerd-shim-benchmarks/benches/wasi-demo-app-benchmarks.rs
Outdated
Show resolved
Hide resolved
jsturtevant
reviewed
Dec 6, 2024
benches/containerd-shim-benchmarks/benches/wasi-demo-app-benchmarks.rs
Outdated
Show resolved
Hide resolved
jsturtevant
reviewed
Dec 6, 2024
benches/containerd-shim-benchmarks/benches/wasi-demo-app-benchmarks.rs
Outdated
Show resolved
Hide resolved
benches/containerd-shim-benchmarks/benches/wasi-demo-app-benchmarks.rs
Outdated
Show resolved
Hide resolved
This commit adds a new benchmark for running the shims end-to-end on wasi-demo-apps to print 'hello'. Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
It seems like that the 'sudo make install' uses a different TARGET_DIR than 'make build' Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
this adds wasi-demo-app OCI image to the benches Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
this commit extract the TestCase out to possibly run any OCI images. It also extract the verify_output out as a closure so that the bench group can customize how to verify the output. Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
f02f9ec to
292a656
Compare
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
It doesn't seem like GitHub has recognized this as an approval, but I will see it as one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new benchmark for running the shims end-to-end on wasi-demo-{app, oci} to print 'hello'.