Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pressable disposes controller only if it creates it #424

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fix: Pressable disposes controller only if it creates it #424

merged 1 commit into from
Aug 2, 2024

Conversation

tilucasoli
Copy link
Collaborator

Description

  • Pressable was disposing the MixWidgetStateController, even when Pressable wasn't the instantiator.

Changes

  • Add a conditional to verify if the Pressable was the one who instantiated.

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

@vercel Vercel
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Aug 2, 2024 9:26pm

@github-actions github-actions bot added the mix label Aug 2, 2024
@tilucasoli tilucasoli requested a review from leoafarias August 2, 2024 21:28
leoafarias
leoafarias approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024 •
edited
Loading

DCM report

✅ no issues found!

Full report: https://github.com/conceptadev/mix/runs/28286651982

@leoafarias leoafarias merged commit 303a593 into main Aug 2, 2024
7 checks passed
@leoafarias leoafarias deleted the fix/pressable-disposal branch August 2, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoafarias leoafarias leoafarias approved these changes

Assignees
No one assigned
Labels
mix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tilucasoli @leoafarias