Fix #5714, so files to be deleted by stack clean --full are not in use
#5715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…full` are not in use The existing: ~~~ cleanCmd = withConfig NoReexec . withBuildConfig . clean ~~~ wraps `clean` in `withBuildConfig`, but that ends in `initProjectStorage projectStorageFile` and, so, uses one of the very files (`projectStorageFile`) that `stack clean -full` will attempt (and fail) to delete. This pull request moves the `withBuildConfig` to wrap only the function that yields the list of files to be deleted (`dirsToDelete cleanOpts`), so that `projectStorageFile` is not in use when the file comes to be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing:
wraps
cleaninwithBuildConfig, but that ends ininitProjectStorage projectStorageFileand, so, uses one of the very files (projectStorageFile) thatstack clean -fullwill attempt (and fail) to delete.This pull request moves the
withBuildConfigto wrap only the function that yields the list of files to be deleted (dirsToDelete cleanOpts), so thatprojectStorageFileis not in use when the file comes to be deleted.Please also shortly describe how you tested your change. Bonus points for added tests! Tested by building
stackand usingstack clean --full.