Skip to content

fix "--resolver global " needs network #5104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2020
Merged

fix "--resolver global " needs network #5104

merged 1 commit into from
Jan 7, 2020

Conversation

diqye
Copy link

@diqye diqye commented Nov 28, 2019

issue: #5103

  • [ x ] Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • [ x ] The documentation has been updated, if necessary.

Test case:

stack test   673 examples, 0 failures
stack --resolver global   is ok
stack --resolver nightly is ok
stack --resolver lts-14   is ok
stack --resolver lts-14.13 is ok

Copy link
Contributor

@qrilka qrilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ppzzppz
Could you also add a changelog entry stating that global doesn't retrieve snapshots list from the internet anymore as it doesn't need it?

@diqye
Copy link
Author

diqye commented Nov 28, 2019

@qrilka Received. Thanks for review.

Could changeLog be written under "Changes since v2.1.3.1"?

Such as the following:

**Changes since v2.1.3.1**

Release notes:

Major changes:

Behavior changes:

Other enhancements:

* Remove warning for using Stack with GHC 8.8 and Cabal 3.0.
* `--resolver global` doesn't retrieve snapshots list from the internet beause doesn't need it

Bug fixes:

@qrilka
Copy link
Contributor

qrilka commented Nov 28, 2019

Surely it's since v2.1.3.1 the question is whether it's an enhancement or a bug fix, I'm a bit more inclined to see it as a bug fix

Copy link
Contributor

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit 6da33ca into commercialhaskell:stable Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants