Skip to content

Fix stack ghci ctrl c 3821 #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Fix stack ghci ctrl c 3821 #3869

merged 2 commits into from
Apr 18, 2018

Conversation

mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Feb 16, 2018

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

@dbaynard
Copy link
Contributor

dbaynard commented Apr 14, 2018

I've rebased this onto current master with dbaynard/stack#fix-stack-ghci-ctrl-c-3821 where it both passes the test suite and fixes the issue. If you want @mgsloan I can PR master directly, replacing this PR?

(Edit: there are some conflicts with very recent commits)

@snoyberg
Copy link
Contributor

Thanks @mgsloan and @dbaynard, merged!

@snoyberg
Copy link
Contributor

@mgsloan I merged in the branch for @dbaynard, but it appears that it didn't completely overlap with your changes here. Can you review and see if this PR can be closed?

@dbaynard
Copy link
Contributor

Yes, please do — it seems fairly straightforward but I'm not familiar with the codebase.

The (non-changelog) conflicting changes were introduced in the 2 commits immediately preceding the base for my rebase.

@snoyberg snoyberg merged commit a9c0eca into master Apr 18, 2018
@snoyberg snoyberg deleted the fix-stack-ghci-ctrl-c-3821 branch April 18, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants