Skip to content

Turn on --install-ghc by default #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Turn on --install-ghc by default #3231

merged 1 commit into from
Jul 13, 2017

Conversation

snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Jun 27, 2017

This is in response to feedback from the Haskell website working group,
who requested this change to ease the new user onboarding process.

NOTE Please feel free to click on the 👍 or 👎 buttons on this description to indicate your support or opposition to this change.

This is in response to feedback from the Haskell website working group,
who requested this change to ease the new user onboarding process.
@bitemyapp
Copy link
Contributor

bitemyapp commented Jun 28, 2017

Strongly in favor. Seems unlikely anyone would be using Stack and not want this. I think a no-install argument so that a failure occurs if GHC is not installed is still a good idea. Helps with things like CI or build scripts that should fail if the environment isn't configured correctly.

@snoyberg
Copy link
Contributor Author

I think a no-install argument... is still a good idea.

Agreed, --no-install-ghc will be available after this change for this purpose. And scripts can be written for both old and new Stack by explicitly putting in one of these arguments at all times.

@vaibhavsagar
Copy link

This doesn't currently work with NixOS, you have to do stack --nix --install-ghc.

@snoyberg
Copy link
Contributor Author

  1. I was under the impression that nix is supposed to maintain its own installation of GHC, since it can't install from standard tarballs
  2. I believe (and could be very mistaken) that stack --nix calls out to a separately downloaded stack executable which would not have this modified behavior. If this is true: this modification would only work seamlessly once officially released

Perhaps some Nix experts can weigh in.

@iand675
Copy link

iand675 commented Jun 28, 2017

I'm in favor. When I pull a new project and run stack build, I tend to leave it for a bit and do something else in anticipation of some build process. I'll come back later and sometimes find that nothing has happened and then I have to context switch again.

@eborden
Copy link

eborden commented Jun 28, 2017

👍

@snoyberg snoyberg merged commit a5d4598 into master Jul 13, 2017
@snoyberg snoyberg deleted the install-ghc-by-default branch July 13, 2017 05:13
@snoyberg
Copy link
Contributor Author

Thanks for the feedback everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants