Support multi line interpreter directive comments #1470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi line block comments can now be used for additional stack arguments
when stack is used as script interpreter. Like this:
{- stack
--verbosity silent
--resolver lts-3.14
--install-ghc
runghc
--package random
--package system-argv0
-}
Newlines are ignored in the block comments. This allows for better
formatting of longer commands.
Previous single line format is supported as usual. The single line
syntax now allows a missing space between comment marker and the start
of command i.e. "--stack ..." too works now.
Updated the guide with complete syntax and semantics.
Closes commercialhaskell#1394
| -- after validating the placement and formatting rules for a valid | ||
| -- interpreter specification. | ||
|
|
||
| interpParser :: String -> Parser Text String |
There was a problem hiding this comment.
Minor nitpick: How about interpreterArgsParser? While we do abbreviate things here and there, it's a bit arbitrary to shorten interpreter to interp.
|
LGTM! Since all I've got is that minor nitpick, I'm going to just merge and add a commit with the rename |
mgsloan
added a commit
that referenced
this pull request
Dec 7, 2015
Support multi line interpreter directive comments
mgsloan
added a commit
that referenced
this pull request
Dec 7, 2015
|
I ended up making the following changes: e44d57c |
|
Great! I was looking for the missing piece i.e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi line block comments can now be used for additional stack arguments
when stack is used as script interpreter. Like this:
Newlines are ignored in the block comments. This allows for better
formatting of longer commands.
Previous single line format is supported as usual. The single line
syntax now allows a missing space between comment marker and the start
of command i.e.
--stack ...too works now.Updated the guide with complete syntax and semantics.
Closes #1394