Skip to content

Delete Stack.Types to improve build times #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sjakobi opened this issue Jul 22, 2016 · 1 comment
Closed

Delete Stack.Types to improve build times #2405

sjakobi opened this issue Jul 22, 2016 · 1 comment
Assignees
@Blaisorblade
Labels
component: code quality newcomer friendly
Milestone
P2: Should

Comments

@sjakobi
Copy link
Member

sjakobi commented Jul 22, 2016

(Split off from #2334)

Modules would then only depend on the Stack.Types.* modules that they actually need and e.g. Stack.Clean wouldn't have to be recompiled after a change in Stack.Types.Nix.
@sjakobi sjakobi added this to the P2: Should milestone Jul 22, 2016
@Blaisorblade Blaisorblade self-assigned this Aug 4, 2016
@Blaisorblade
Copy link
Collaborator

Done for the library, doing it for tests.
According to the PVP, this would forces a version bump to 1.2. Should I readd Stack.Types in or bump the version?

In my last change related to #2334 (0628ff1), I left reexports in to keep the same API and didn't wonder about the PVP.

Blaisorblade added a commit that referenced this issue Aug 4, 2016
@Blaisorblade
Remove references to Stack.Types to speedup builds
f29d496 
See #2405.
Blaisorblade added a commit that referenced this issue Aug 4, 2016
@Blaisorblade
Remove Stack.Types and bump version
9a21616 
Fix #2405.
@Blaisorblade Blaisorblade mentioned this issue Aug 4, 2016
Merged
Blaisorblade added a commit that referenced this issue Aug 4, 2016
@Blaisorblade
Remove Stack.Types to speedup builds
da44f86 
Fix #2405.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Blaisorblade Blaisorblade

Labels
component: code quality newcomer friendly
Projects
None yet
Milestone
P2: Should
Development

No branches or pull requests
3 participants
@Blaisorblade @borsboom @sjakobi