Skip to content

Benchmarks are executed in parallel with other tasks #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgsloan opened this issue Mar 15, 2016 · 3 comments
Closed

Benchmarks are executed in parallel with other tasks #1913

mgsloan opened this issue Mar 15, 2016 · 3 comments
Labels
type: enhancement
Milestone
P1: Must

Comments

@mgsloan
Copy link
Contributor

mgsloan commented Mar 15, 2016

This probably isn't what we want, as it can affect benchmark results!
@mgsloan mgsloan added this to the P2: Should milestone Mar 15, 2016
@mgsloan mgsloan mentioned this issue Mar 15, 2016
Open
@rrnewton rrnewton mentioned this issue Apr 18, 2016
Open
@rrnewton
Copy link
Contributor

Yes, this makes the benchmark results by default corrupt!

@mgsloan
Copy link
Contributor Author

mgsloan commented Apr 18, 2016

Agreed, bumping to P1

@mgsloan mgsloan modified the milestones: P1: Must, P2: Should Apr 18, 2016
@mgsloan
Copy link
Contributor Author

mgsloan commented Apr 29, 2016 •
edited
Loading

Hah, upon looking into this I found that the logic is already there to run tests and benchmarks sequentially:

stack/src/Control/Concurrent/Execute.hs

Line 111 in d63395e

(ActionId _ ATFinal, Just lock) -> do

My mistake

@mgsloan mgsloan closed this as completed Apr 29, 2016
@AndreasPK AndreasPK mentioned this issue Dec 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
P1: Must
Development

No branches or pull requests
2 participants
@mgsloan @rrnewton