Skip to content

Fix #4 Allow dependency on mtl >= 2.3 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

mpilgrem
Copy link
Member

From mtl-2.3, Control.Monad.State no longer re-exports Control.Monad.when.

Also avoids warning in respect of the Data.Semigroup import.

Also bumps stack.yaml to a recent version of GHC (as earlier version fails on Windows).

Tested by building with Stack with a dependency on mtl-2.3.

From mtl-2.3, `Control.Monad.State` no longer re-exports `Control.Monad.when`.

Also avoids warning in respect of the `Data.Semigroup` import.

Also bumps `stack.yaml` to a recent version of GHC (as earlier version fails on Windows).
@mpilgrem
Copy link
Member Author

@snoyberg, I do not know why all the CI was 'cancelled' but I have tested this pull request on Windows with GHC 9.0.2.

@snoyberg
Copy link
Collaborator

No idea why, but switching to GitHub Actions is probably a good idea regardless.

@mpilgrem
Copy link
Member Author

mpilgrem commented Aug 11, 2022

@snoyberg, I should have been express: could this pull request be considered for merger by you, not withstanding the cancelled CI? (I do not have commit rights for this repository and I noted it was you who had merged all past pull requests.) EDIT: Scratch that request, I must have been mistaken, I now have commit rights.

I think converting the CI to use GitHub Actions is within my capabilities. I will look at that separately.

@mpilgrem mpilgrem merged commit 957f312 into commercialhaskell:master Aug 11, 2022
@mpilgrem mpilgrem deleted the fix4 branch August 11, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants