Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update python script to support Python3 #878

Merged
merged 6 commits into from
Feb 17, 2021
Merged

update python script to support Python3 #878

merged 6 commits into from
Feb 17, 2021

Conversation

lifegpc
Copy link

@lifegpc lifegpc commented Feb 4, 2021

I test it with Python 3.7.4. Works well.

@clsid2
Copy link
Owner

clsid2 commented Feb 11, 2021

I assume this is not backwards compatible with v2?
In that case the compilation instructions document also needs to be updated.

@lifegpc
Copy link
Author

lifegpc commented Feb 11, 2021

yea.

@lifegpc
Copy link
Author

lifegpc commented Feb 11, 2021

done.

ghost
ghost suggested changes Feb 13, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use the currently latest version (3.9.1) of Python in the document.

@lifegpc
Copy link
Author

lifegpc commented Feb 17, 2021

Maybe I can change it to 3.8. 3.9 can not used on win7.

@clsid2
Copy link
Owner

clsid2 commented Feb 17, 2021

3.8.7 works in Win7

@clsid2 clsid2 merged commit 542712e into clsid2:develop Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lifegpc @clsid2