Add RSA-SHA1 support #121
Merged
Add RSA-SHA1 support #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/wraithgar/node-oauth. Added test that uses the RSA-SHA1 method and verifies the signature using a public key.
Closed
|
Thanks for getting this put together. |
|
Hello all. Any reason why this hasn't been merged in? |
|
Merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on a fork from https://github.com/wraithgar/node-oauth. All I did was to basically add a test that ensures creating a signature with RSA-SHA1 works and that this signature can then be verified with a matching public key.
(See comments in #43).
I also verified that this works against a working OAuth service provider using RSA-SHA1 (Atlassian JIRA).