-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use latest version SDK and go #63
Conversation
30d5b0c
to
5b9e4f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know anything about buildx plugin
would let others review that part. I only reviewed the Go version change. Just confirming, Did you also repeated the testing after updating the Go version?
a563ca9
to
f0aa42a
Compare
Push above remove change in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version change LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this change; the SDK already has the ability to build binaries for the correct target architecture without involving buildx.
Have you run into problems using the SDK for that?
f0aa42a
to
77a84b8
Compare
77a84b8
to
affd095
Compare
Convert it to draft and will make sure if new change meets @samuelkarp 's expectation. solution: |
affd095
to
7707359
Compare
this change will make brupop use latest version SDK and fix aarch64 building failure issue.
7707359
to
c451ec2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue number:
#52
Description of changes:
Testing done:
Building images
2.Push image to ECR Public, and deploy to an aarch64 bottlerocket host. and Extract logs to check if it run successfully
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.