Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WASI platform support #169

Closed
wants to merge 2 commits into from
Closed

Update WASI platform support #169

wants to merge 2 commits into from

Conversation

whitequark
Copy link
Contributor

This is essentially a part of #144 that I've missed because I tested against an outdated version of Boost at that time. See that PR for details.

@Lastique
Copy link
Member

If there is no access mode in WASI, then I'd prefer to also disable adding S_IWUSR above, along with its associated comment.

@whitequark
Copy link
Contributor Author

Something like this?

@Lastique
Copy link
Member

More like this:

mode_t to_mode = from_mode;
#if !defined(__wasm)
...
#endif

@Lastique
Copy link
Member

Merged to develop.

@Lastique Lastique closed this Dec 23, 2020
@whitequark
Copy link
Contributor Author

Thanks!

@whitequark whitequark deleted the patch-1 branch December 23, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants