Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddb-enhanced: Annotated immutable class introspector now ignores 'toB… #2735

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

bmaizels
Copy link
Contributor

…uilder' method allowing easier integration with libraries that auto-generate this method on immutable data classes.

Motivation and Context

This partially addresses concerns raised in #1932.

Description

When using immutable annotated classes with the enhanced DynamoDB client, any methods named 'toBuilder' will be ignored by the introspection code which will enable smoother integration with libraries that automatically generate these methods on immutable data objects (such as Lombok).

Testing

Unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

…uilder' method allowing easier integration with libraries that auto-generate this method on immutable data classes.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zoewangg zoewangg merged commit b95947d into master Sep 24, 2021
@zoewangg zoewangg deleted the bmaizels-ddbenhanced-ignoreToBuilder branch September 24, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants