Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back support for S3 Control #1458

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Adding back support for S3 Control #1458

merged 2 commits into from
Oct 7, 2019

Conversation

spfink
Copy link
Contributor

@spfink spfink commented Oct 7, 2019

Brings #1449 back in with the correct path for the execution.interceptors file. Intellij had initially created a folder "software.amazon.awssdk.services.s3control" instead of making each of those a folder.

@spfink spfink force-pushed the finks/s3-control-2 branch 2 times, most recently from 61a6115 to 1dd5763 Compare October 7, 2019 18:43
@codecov-io
Copy link

Codecov Report

Merging #1458 into master will increase coverage by 0.04%.
The diff coverage is 78.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1458      +/-   ##
============================================
+ Coverage     73.73%   73.78%   +0.04%     
- Complexity      660      684      +24     
============================================
  Files           845      848       +3     
  Lines         25893    25995     +102     
  Branches       1970     1992      +22     
============================================
+ Hits          19092    19180      +88     
- Misses         5942     5955      +13     
- Partials        859      860       +1
Flag Coverage Δ Complexity Δ
#unittests 73.78% <78.84%> (+0.04%) 684 <24> (+24) ⬆️
Impacted Files Coverage Δ Complexity Δ
...sdk/services/s3control/S3ControlConfiguration.java 65% <65%> (ø) 6 <6> (?)
...ternal/interceptors/PayloadSigningInterceptor.java 80% <80%> (ø) 3 <3> (?)
...ernal/interceptors/EndpointAddressInterceptor.java 88.88% <88.88%> (ø) 15 <15> (?)
...tomization/CodegenCustomizationProcessorChain.java 81.81% <0%> (-8.19%) 0% <0%> (ø)
...on/awssdk/protocols/ion/AwsIonProtocolFactory.java 72.72% <0%> (-5.06%) 0% <0%> (ø)
.../software/amazon/awssdk/core/sync/RequestBody.java 89.28% <0%> (-3.31%) 0% <0%> (ø)
...ftware/amazon/awssdk/codegen/internal/Jackson.java 59.09% <0%> (-2.82%) 0% <0%> (ø)
...on/awssdk/codegen/internal/DocumentationUtils.java 74.19% <0%> (-2.48%) 0% <0%> (ø)
...db/mappingclient/extensions/WriteModification.java 52% <0%> (-2.17%) 5% <0%> (ø)
...amodb/mappingclient/operations/ConditionCheck.java 41.66% <0%> (-1.2%) 3% <0%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb806a...1dd5763. Read the comment docs.

@spfink spfink force-pushed the finks/s3-control-2 branch from 2598dfa to addd875 Compare October 7, 2019 19:27
@spfink spfink merged commit 3c4395b into master Oct 7, 2019
@spfink spfink deleted the finks/s3-control-2 branch March 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants