Skip to content

Add slow-test reporting to nextest in CI #15662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Add slow-test reporting to nextest in CI #15662

merged 3 commits into from
Jan 22, 2025

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jan 21, 2025

This is helpful for spotting tests that are running slow. In uv, we use a 10s threshold. Here, it looks like we could use something smaller.

e.g.

Screenshot 2025-01-21 at 6 08 00 PM

@zanieb zanieb added the internal An internal refactor or improvement label Jan 21, 2025
Comment on lines +10 to +15
# Mark tests that take longer than 1s as slow.
# Terminate after 60s as a stop-gap measure to terminate on deadlock.
slow-timeout = { period = "1s", terminate-after = 60 }

# Show slow jobs in the final summary
final-status-level = "slow"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration copied from uv.

Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zanieb zanieb merged commit d4efef2 into main Jan 22, 2025
21 checks passed
@zanieb zanieb deleted the zb/slow-tests branch January 22, 2025 07:09
@MichaReiser MichaReiser added ci Related to internal CI tooling and removed internal An internal refactor or improvement labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to internal CI tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants