Skip to content

KAFKA-18247: Use log4j2 yaml to rewrite the fix of KAFKA-18145 #18192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

Yunyung
Copy link
Collaborator

@Yunyung Yunyung commented Dec 15, 2024

As mentioned in the Jira, add the fix for KAFKA-18145 to the log4j2 yaml, so the test_dynamic_logging test can use a non-root logger.

Jira: https://issues.apache.org/jira/browse/KAFKA-18247

For verification, we need to wait until #18185 gets fixed.

Before:

TBD

After:

TBD

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community tests Test fixes (including flaky tests) small Small PRs labels Dec 15, 2024
@chia7712
Copy link
Member

[DEBUG - 2024-12-16 04:50:20,257 - connect_distributed_test - test_dynamic_logging - lineno:464]: Listed all loggers via REST API: {'': {'level': 'DEBUG', 'last_modified': None}, 'org.apache.kafka.clients.consumer.ConsumerConfig': {'level': 'ERROR', 'last_modified': None}, 'root': {'level': 'DEBUG', 'last_modified': None}}

run tests/kafkatest/tests/connect/connect_distributed_test.py::ConnectDistributedTest.test_dynamic_logging with this patch, and the required logger is existent now. +1

@chia7712 chia7712 merged commit 9cc1547 into apache:trunk Dec 16, 2024
2 of 3 checks passed
@github-actions github-actions bot removed the triage PRs from the community label Dec 19, 2024
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-approved small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants