Skip to content

KAFKA-16559 allow defining number of disks per broker in TestKitNodes #15776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2024
Merged

KAFKA-16559 allow defining number of disks per broker in TestKitNodes #15776

merged 1 commit into from
Apr 22, 2024

Conversation

gaurav-narula
Copy link
Contributor

@gaurav-narula gaurav-narula commented Apr 22, 2024 •
edited
Loading

Cherry-picks #15730 to 3.7 branch.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@gaurav-narula
Copy link
Contributor Author

CC: @soarez @chia7712

@gaurav-narula gaurav-narula mentioned this pull request Apr 22, 2024
Merged
3 tasks
soarez
soarez reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@soarez soarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM changes are identical to #15730

@soarez
Copy link
Member

soarez commented Apr 22, 2024

There is a large number of failed tests, but none of them are new

chia7712
chia7712 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chia7712 chia7712 mentioned this pull request Apr 22, 2024
Merged
3 tasks
@chia7712
Copy link
Member

@soarez Any concerns? The failed streams tests can get fixed by backporting #14983. Hence, I'd like to merge it :)

soarez
soarez approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@soarez soarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM please merge @chia7712

@chia7712 chia7712 merged commit 0c8552a into apache:3.7 Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soarez soarez soarez approved these changes

@chia7712 chia7712 chia7712 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaurav-narula @soarez @chia7712