KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error -- Addressing the error server side #12968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hachikuji
reviewed
Dec 9, 2022
core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala
Show resolved
Hide resolved
hachikuji
reviewed
Dec 12, 2022
core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala
Show resolved
Hide resolved
core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala
Outdated
Show resolved
Hide resolved
hachikuji
pushed a commit
that referenced
this pull request
Dec 19, 2022
…`InitProducerId` (#12968) Older clients can not handle the `REQUEST_TIMED_OUT` error that is returned from `InitProducerId` when the next producerId block cannot be fetched from the controller. In this patch, we return `COORDINATOR_LOAD_IN_PROGRESS` instead which is retriable. Reviewers: Jason Gustafson <[email protected]>
hachikuji
pushed a commit
that referenced
this pull request
Dec 19, 2022
…`InitProducerId` (#12968) Older clients can not handle the `REQUEST_TIMED_OUT` error that is returned from `InitProducerId` when the next producerId block cannot be fetched from the controller. In this patch, we return `COORDINATOR_LOAD_IN_PROGRESS` instead which is retriable. Reviewers: Jason Gustafson <[email protected]>
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
…`InitProducerId` (apache#12968) Older clients can not handle the `REQUEST_TIMED_OUT` error that is returned from `InitProducerId` when the next producerId block cannot be fetched from the controller. In this patch, we return `COORDINATOR_LOAD_IN_PROGRESS` instead which is retriable. Reviewers: Jason Gustafson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older clients can not handle REQUEST_TIMED_OUT, so the error is changed to COORDINATOR_LOAD_IN_PROGRESS which is retriable and the desired behavior.
Committer Checklist (excluded from commit message)