🐛 prevents coercion of space and underscore to minus #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanding the keydown modifiers test introduced some issues regarding ensuring the these options were all treated separately without overlap.
SimoTod
reviewed
Sep 4, 2022
marcreichel
suggested changes
Sep 4, 2022
Co-authored-by: Marc Reichel <[email protected]>
marcreichel
approved these changes
Sep 15, 2022
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses bug found in #3124
This PR:
' 'and'_'from being coerced into'-'in thekebabcasefunction.minusandunderscoreas aliases for-and_when using them as@keydownmodifiers.This will break any apps that actually depends on this coercion, but I don't think that would be an expected behavior that anyone would be relying on.